ext4: fix check for block being out of directory size
authorJan Kara <jack@suse.cz>
Mon, 22 Aug 2022 11:48:32 +0000 (13:48 +0200)
committerSalvatore Bonaccorso <carnil@debian.org>
Fri, 21 Oct 2022 20:24:21 +0000 (21:24 +0100)
commit03ea89112edc296a1a6c3549966882ef5721da97
tree6719eef75c52cffd40e75a2e5480041103ac4550
parentcf0bb1c58f7ffe48443b6deebf3dc5b82efee9b5
ext4: fix check for block being out of directory size

commit 61a1d87a324ad5e3ed27c6699dfc93218fcf3201 upstream.

The check in __ext4_read_dirblock() for block being outside of directory
size was wrong because it compared block number against directory size
in bytes. Fix it.

Fixes: 65f8ea4cd57d ("ext4: check if directory block is within i_size")
CVE: CVE-2022-1184
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Link: https://lore.kernel.org/r/20220822114832.1482-1-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name ext4-fix-check-for-block-being-out-of-directory-size.patch
fs/ext4/namei.c